Script: alert when ally is reclaiming other ally frames

I'd like to be alerted if there's someone on my team reclaiming ally build frames. It's 99% of the time sabotage of your own team to gain metal and goes unnoticed since the build effect looks so similar.

EDIT: I've made a script that does what I wanted https://zero-k.info/Forum/Post/251698#251698

Is that something a widget could watch?

upvotes dont matter. life is meaningless.

An hour of copy pasting and I've made a functional script that marks trolls.

function widget:GetInfo()
	return {
		name      = "Ally Troll Reclaim Alert",
		desc      = "",
		author    = "",
		date      = "",
		license   = "",
		layer     = 20,
		enabled   = true
	}
end

local gameID_to_playerName

function widget:Initialize()
	gameID_to_playerName = {}
	local teamList = Spring.GetTeamList() --//check teamIDlist for AI
	for j= 1, #teamList do
		local teamID = teamList[j]
		local _,playerID, _, isAI = Spring.GetTeamInfo(teamID, false)
		if isAI then
			local _, aiName = Spring.GetAIInfo(teamID)
			gameID_to_playerName[teamID] = "[AI]"..aiName
		elseif not isAI then
			local playerName = Spring.GetPlayerInfo(playerID, false)
			gameID_to_playerName[teamID] = playerName or "Gaia"
		end
	end
end

function widget:UnitCommand(unitID, unitDefID, unitTeam, cmdID, cmdParams, cmdOpts, cmdTag)
	if (not Spring.ValidUnitID(unitID)) then
		return --invalid unit ID
	end

	if (cmdID ~= 90) then
		return --not reclaim command
	end
	
	if (type(cmdParams) ~= "table") then
		return --corrupted command parameters
	end
	
	if (cmdParams[2]) then
		return --more than 1 param: not targetID but actually X,Y,Z position for area-reclaim
	end
	
	local targetUnitID = cmdParams[1]
	if ((type(cmdParams[1]) ~= "number") or (not Spring.ValidUnitID(targetUnitID))) then
		return --invalid unit ID
	end
	
	local targetUnitTeamID = Spring.GetUnitTeam(targetUnitID)
	if (targetUnitTeamID == unitTeam) then
		return --target is on origin team
	end
	
	local health,maxHealth,paralyzeDamage,captureProgress,buildProgress = Spring.GetUnitHealth(targetUnitID)
	if ((type(buildProgress) ~= "number") or (buildProgress >= 1)) then
		return --not a unit frame
	end
	
	local originAllyTeamID = Spring.GetUnitAllyTeam(unitID)
	local targetUnitAllyTeamID = Spring.GetUnitAllyTeam(targetUnitID)
	
	if (originAllyTeamID ~= targetUnitAllyTeamID) then
		return --not allied
	end
	
	local perpetratorName = gameID_to_playerName[unitTeam]
	local victimName = gameID_to_playerName[targetUnitTeamID]
	
	local message = "ALERT: '"..perpetratorName.."' is attempting to reclaim property of '"..victimName.."'"
	
	local x,y,z = Spring.GetUnitPosition(unitID)
	Spring.MarkerAddPoint(x,y,z,perpetratorName,true)
	Spring.MarkerErasePosition(x,y,z)
	
	x,y,z = Spring.GetUnitPosition(targetUnitID)
	Spring.MarkerAddPoint(x,y,z,message,true)
	Spring.MarkerErasePosition(x,y,z)
end

It only creates markers you can see according to documentation. Zero testing in a real game but it worked when I gifted to AI and tried reclaiming it. I don't know how to check if a unit order is "valid", that is whether the target is a frame and not a finished building (which would be an invalid order that never executes) so it might display some false positives.

I've now tested it on a replay https://zero-k.info/Battles/Detail/1426584 and it has detected multiple instances where lKomandante sneakily reclaims ally unit frames inside factories. I think it's working fine.

quote: I don't know how to check if a unit order is "valid", that is whether the target is a frame and not a finished building

GetUnitHealth returns a tuple which includes buildProgress. Anything below 1 is a nanoframe.

Since it's so easy to detect this, and it is only ever done by trolls to steal from team, it should be prevented from happening at all. There's no valid reason to ever start reclaiming what an ally is building inside their factory.

Just don't allow the command to be issued.

Perfect is the enemy of good, it can be a temporary measure to block malicious commands until the feature you mentioned catches up.

Punishing people is not the goal, it's the most destructive bandaid on an issue that can be easily prevented.

I'm seeing false positives when someone issues an area reclaim order of some sort, assuming centered on a unit. I don't know why it's happening. It detected katastrophe trying to reclaim Sab in https://zero-k.info/Battles/Detail/1487169 but the units had no such orders when I checked, they were reclaiming wrecks.